drop the unused newtonsoft version entry - #10
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
=======================================
Coverage 90.29% 90.29%
=======================================
Files 505 505
Lines 10762 10762
Branches 999 999
=======================================
Hits 9718 9718
Misses 708 708
Partials 336 336
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newtonsoft.Jsonhad aPackageVersionentry inDirectory.Packages.propswith noconsumer: no
.csprojreferenced it, no source file used it, and noproject.assets.jsonresolved it. Left over from theSystem.Text.Jsonmigration.Harmless on its own, but
src/management/CLAUDE.mdsays "Newtonsoft is gone; do notreintroduce it" - and a live version entry is what lets someone add a
PackageReferenceand have it restore cleanly without noticing they just brought itback. Removing the entry means that attempt now fails with NU1008 instead.
Central transitive pinning is not enabled, so nothing resolved through this entry
either. Restore, both build legs at 0 warnings, and all 9 suites green.